Fix timestep columns #371
Merged
Fix timestep columns #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adapts the timestep output of the new flux kernels to the one of the LEGACY flux kernel as (for some reason) the ul and ur values get swapped in the very last step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy flux kernel swaps UL and UR when storing the respective values for the time step:
octotiger/octotiger/unitiger/hydro_impl/flux.hpp
Line 111 in f2a9c5d
octotiger/octotiger/unitiger/hydro_impl/flux.hpp
Line 112 in f2a9c5d
The newer hydro flux kernels (all of them, VC, CUDA, Kokkos) were not doing this, causing swapped ur/ul and vr/vl columns in the time step output on the console!
@dmarce1 @shibersag I assume the UL/UR swap in the legacy mentioned above is intentional? In case it is: This PR adds the swap when storing UL and UR in the time step variable for all kernels.