Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Main, DSpot and Amplification #923

Closed
wants to merge 12 commits into from

Conversation

andrewbwogi
Copy link
Contributor

No description provided.

@andrewbwogi
Copy link
Contributor Author

Hi @danglotb, eu.stamp_project.utils.DSpotUtilsTest is failing for me with f737ce0. Is the expected value in testWithLombokAnnotation() correct?

@danglotb
Copy link
Member

Hello @andrewbwogi

Thank you for your PR. Yes, it seems that I may wrongly updated an expected value in the DSpotUtilsTest.

I'm looking at it.

@danglotb
Copy link
Member

danglotb commented Nov 26, 2019

Hello @andrewbwogi

To resolve the conflict, we must move the new code

if (testMethodsToBeAmplifiedNames.size() == 1 &&
                testMethodsToBeAmplifiedNames.get(0).isEmpty()) {
    testMethodsToBeAmplifiedNames.clear();
}

from the Main class to the new location. Could you take care of that?

There is also a failing test on dspot-diff-test-selection. According to the trace, resolving the conflict would fix the test.

Thank you.

@danglotb
Copy link
Member

Hello @andrewbwogi

Because we are bit in a hurry, I close this one and merge the one that I opened #928

I won't squash the commits in order to keep your authorship.

Best.

@danglotb danglotb closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants