Dev friendly amp improvements and windows support #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on[s] for clarity
|
Might address #1001 |
danglotb
reviewed
Nov 5, 2021
| .getFile() + | ||
| AmplificationHelper.PATH_SEPARATOR + dependencies; | ||
| } | ||
| // if (!dependencies.contains("junit" + File.separator + "junit" + File.separator + "4")) { |
There was a problem hiding this comment.
If this code is no longer useful, please remove it completely
danglotb
approved these changes
Nov 5, 2021
|
Hi @lacinoire |
|
Hey @danglotb, |
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
============================================
+ Coverage 72.73% 72.91% +0.17%
- Complexity 1482 1486 +4
============================================
Files 134 134
Lines 6359 6364 +5
Branches 757 757
============================================
+ Hits 4625 4640 +15
+ Misses 1395 1386 -9
+ Partials 339 338 -1
Continue to review full report at Codecov.
|
lacinoire
deleted the
dev-friendly-amp-improvements-and-windows-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required to change the test cases including CommentTest#testAmplifierComments, hopefully making it no longer flaky.
The amplification is still non-deterministic, though the test now only checks for presence of the comment, not the exact change that was made in the test.