Skip to content

Commit

Permalink
Merge branch 'infra/preflight/inline-script' into ST-DDT-patch-1
Browse files Browse the repository at this point in the history
  • Loading branch information
ST-DDT committed Oct 16, 2024
2 parents 956061e + c8dbd64 commit 717f45b
Show file tree
Hide file tree
Showing 3 changed files with 65 additions and 121 deletions.
73 changes: 0 additions & 73 deletions .github/workflows/commentCodeGeneration.ts

This file was deleted.

68 changes: 65 additions & 3 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,29 @@
name: PR

on:
pull_request:
pull_request_target:

permissions:
contents: read # to fetch code (actions/checkout)
permissions: {} # Permissions per job

jobs:
check-code-generation:
runs-on: ubuntu-latest
timeout-minutes: 10
name: 'Check Code Generation: node-22, ubuntu-latest'
permissions:
# Do not add any additional permissions here, as these can be used by third-party contributors
contents: read # to fetch code (actions/checkout)
outputs:
generate: ${{ steps.generate.outcome }}
diff: ${{ steps.diff.outcome }}

steps:
- name: Checkout
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}

- name: Install pnpm
uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # v4.0.0
Expand Down Expand Up @@ -54,3 +61,58 @@ jobs:
- name: Status
if: ${{ steps.generate.outcome == 'failure' || steps.diff.outcome == 'failure' }}
run: exit 1

write-comment:
runs-on: ubuntu-latest
timeout-minutes: 5
name: 'Comment Code Generation'
permissions:
pull-requests: write # to write the comment
needs: check-code-generation
if: ${{ always() }}

steps:
- name: Write comment
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
script: |
const repoArgs = { owner: context.repo.owner, repo: context.repo.repo };
const issue_number = context.issue.number;
// Check if the PR already has a comment from the bot
const { data: comments } = await github.rest.issues.listComments({
...repoArgs,
issue_number,
});
const body = `GitHub Actions has found some problems running the preflight checks.
Please make sure to:
- run \`pnpm run preflight\` locally
- fix all issues until the command completes without errors
- commit and push the changes
`;
const botComment = comments.find(
(comment) => comment.user?.type === 'Bot' && comment.body?.includes(body)
);
const generateSuccess = ${{ needs.check-code-generation.outputs.generate == 'success' }};
const diffSuccess = ${{ needs.check-code-generation.outputs.diff == 'success' }};
if (generateSuccess && diffSuccess) {
// Delete the bot comment if present
if (botComment != null) {
await github.rest.issues.deleteComment({
...repoArgs,
comment_id: botComment.id,
});
}
} else {
// Create the comment if missing
if (botComment == null) {
await github.rest.issues.createComment({
...repoArgs,
issue_number,
body,
});
}
}
45 changes: 0 additions & 45 deletions .github/workflows/preflight-comment.yml

This file was deleted.

0 comments on commit 717f45b

Please sign in to comment.