client: add native sharer #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
force-pushed
the
share-fun
branch
2 times, most recently
from
4dfdd9c
to
2ca1e6e
Compare
|
It is not supported outside of Chrome, and even there it is behind a flag. It probably should not be merged yet. |
|
This is supported by Safari in addition to Chrome on Android so it is time to add this. |
|
I successfully shared a link on Chrome for Android. Though, currently, the sharers have a bug, where they will include some accessibility markup. Also on desktop Chromium, the button is shown, even when there are no targets, resulting in |
|
Also this feature is secure-context only (HTTPS). |
using Web Share API for browsers that support it https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share Note that this is still experimental and it will also only work in secure contexts (HTTPS). Closes: #719
Use ES6 syntax
selfoss.shares.register now has the following signature:
(name: String
, id: String
, fontawesomeIconClass: String
, ({url: String, title: String} -> Void
) -> bool
During the accessibility improvements we changed the structure of entry title but forgot to update the sharers to reflect the changes.
Instead of just “facebook” or “pocket”, use “Share on Facebook” and “Save to Pocket” as the labels and tooltips of the sharing buttons. This will make it slightly clearer.
This again changes the signature of selfoss.shares.register:
(name: String
, id: String
, label: String
, fontawesomeIconClass: String
, ({url: String, title: String} -> Void
) -> bool
so that users can register their own with emoji icons. Also update NEWS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Web Share API for browsers that support it
Closes: #719