Test: Check the TGT of user after auth for passkey #7393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerexxe
reviewed
May 23, 2024
madhuriupadhye
force-pushed
the
check_klist_tgt
branch
from
b8e1c1b
to
c7e7b5a
Compare
|
I ran a manual test with sssd-2.10 installed and it worked but, I still had to modify the IPA container's [email protected] file to add: Is there already a PR in the works to handle that? |
madhuriupadhye
force-pushed
the
check_klist_tgt
branch
2 times, most recently
from
1e4d775
to
c6cc2ad
Compare
spoore1
requested changes
May 26, 2024
pbrezina
reviewed
May 27, 2024
madhuriupadhye
force-pushed
the
check_klist_tgt
branch
from
c6cc2ad
to
a51b7cc
Compare
pbrezina
reviewed
May 28, 2024
madhuriupadhye
force-pushed
the
check_klist_tgt
branch
3 times, most recently
from
b66c8ef
to
2515543
Compare
pbrezina
requested changes
Jun 4, 2024
madhuriupadhye
force-pushed
the
check_klist_tgt
branch
from
2515543
to
c0e633f
Compare
madhuriupadhye
force-pushed
the
check_klist_tgt
branch
from
c0e633f
to
cdfac59
Compare
madhuriupadhye
force-pushed
the
check_klist_tgt
branch
2 times, most recently
from
e9d88d5
to
def0ec5
Compare
madhuriupadhye
added
Waiting for review
backport-to-stable
passkey
pbrezina
reviewed
Jun 6, 2024
| def umockdev_ipaotpd_update(ipa: IPA, request: pytest.FixtureRequest): | ||
| """ | ||
| Update the [email protected] file from ipa server | ||
| for umockdev |
There was a problem hiding this comment.
Can you add more information here about why is this needed and when it is needed? I'm pretty sure we will forget it sooner or later. Otherwise ack!
There was a problem hiding this comment.
okay, let me add more, I may not forget but good to have more details description. Thank you!
Add the test case of passkey where we are checking TGT of user after successful auth with IPA server. Also add the fixture to update the [email protected] file from server to make sure umockdev-run authenticate the user without showing data mis match error. Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
force-pushed
the
check_klist_tgt
branch
from
def0ec5
to
852492f
Compare
pbrezina
approved these changes
Jun 7, 2024
pbrezina
added
Accepted
Ready to push
|
There was a conflict in sssd-2-9. Please, open a standalone pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the test case of passkey where we are checking
TGT of user after successful auth with IPA server.
Also add the fixture to update the [email protected]
file from server to make sure umockdev-run authenticate
the user without showing data mismatch error.