Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TESTS: Porting sss_override test suite #6717

Closed
wants to merge 1 commit into from
Closed

TESTS: Porting sss_override test suite #6717

wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented May 5, 2023

No description provided.

@danlavu danlavu added the Tests label May 5, 2023
@danlavu danlavu self-assigned this May 5, 2023
@danlavu danlavu requested a review from pbrezina May 5, 2023 18:34
@danlavu danlavu force-pushed the local_overrides branch 2 times, most recently from bf8e95f to 4a4f18b Compare May 24, 2023 04:03
@danlavu danlavu requested a review from spoore1 May 24, 2023 04:06
@danlavu
Copy link
Author

danlavu commented May 24, 2023 •
edited
Loading

============================= test session starts ==============================
collecting ... collected 12 items

tests/test_local_overrides.py::test_local_overrides__user (ad)
tests/test_local_overrides.py::test_local_overrides__user (ldap)
tests/test_local_overrides.py::test_local_overrides__group (ad)
tests/test_local_overrides.py::test_local_overrides__group (ldap)
tests/test_local_overrides.py::test_local_overrides__root_user (ad)
tests/test_local_overrides.py::test_local_overrides__root_user (ldap)
tests/test_local_overrides.py::test_local_overrides__nested (ad)
tests/test_local_overrides.py::test_local_overrides__nested (ldap)
tests/test_local_overrides.py::test_local_overrides__import_export (ad)
tests/test_local_overrides.py::test_local_overrides__import_export (ldap)
tests/test_local_overrides.py::test_local_overrides__fqdn_true (ad)
tests/test_local_overrides.py::test_local_overrides__fqdn_true (ldap)

======================== 12 passed in 71.55s (0:01:11) =========================
PASSED [ 8%]PASSED [ 16%]PASSED [ 25%]PASSED [ 33%]PASSED [ 41%]PASSED [ 50%]PASSED [ 58%]PASSED [ 66%]PASSED [ 75%]PASSED [ 83%]PASSED [ 91%]PASSED [100%]
Process finished with exit code 0

@danlavu danlavu marked this pull request as ready for review May 24, 2023 04:09
@danlavu danlavu mentioned this pull request May 24, 2023
Merged
spoore1
spoore1 requested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, suggestions, and questions.

src/tests/system/tests/test_local_overrides.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_local_overrides.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_local_overrides.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_local_overrides.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_local_overrides.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_local_overrides.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_local_overrides.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_local_overrides.py Outdated Show resolved Hide resolved
@danlavu danlavu force-pushed the local_overrides branch 3 times, most recently from 6ed82d0 to 18a3124 Compare May 25, 2023 12:36
@andreboscatto andreboscatto assigned spoore1 and pbrezina and unassigned danlavu May 25, 2023
@danlavu danlavu force-pushed the local_overrides branch 2 times, most recently from 8afbe1d to 9daee9a Compare May 25, 2023 19:49
@danlavu danlavu force-pushed the local_overrides branch 2 times, most recently from 465f6dc to dd01d50 Compare June 5, 2023 14:11
spoore1
spoore1 reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mypy errors and the fedora system test failures are due to the dependent PR here:

SSSD/sssd-test-framework#8

I'm expecting once that is merged this will go green or much more of it will anyway.

src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
pbrezina
pbrezina requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dan, thank you. I think this is a good start, there are just few things that I wanted to explain. Please, see comments inside.

src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Show resolved Hide resolved
@pbrezina
Copy link
Member

sss_override API in sssd-test-framework is now merged, please, let me know when this PR is ready for next round of review

pbrezina
pbrezina requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@pbrezina pbrezina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dan, excellent work. I have some comments to improve readability, all of them applies to the whole code (and future tests you will write). But no functional changes.

You also need to add :requirement: metadata and it would be good to provide assert message to places when failure may not be clear (i.e. assert result is not None, "User was not found"

src/tests/system/tests/test_sss_override.py Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
@danlavu danlavu changed the title Adding sss_override tests TESTS: Porting sss_override test suite Aug 9, 2023
pbrezina
pbrezina requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, after these two changes, ack.

src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
@danlavu danlavu force-pushed the local_overrides branch 4 times, most recently from 03ac2a6 to 35f4583 Compare August 25, 2023 02:25
pbrezina
pbrezina requested changes Aug 30, 2023
View reviewed changes
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sss_override.py Outdated Show resolved Hide resolved
@pbrezina
Copy link
Member

@sidecontrol Ack. Is there any reason why this should not go to sssd-2-9? It does not test any new functionality, it just ports the tests so imho we can backport it so we run these tests again 2.9.* builds in downstream?

@danlavu
Copy link
Author

danlavu commented Aug 31, 2023

I was thinking, no reason, added 2-7 and 2-8

@pbrezina pbrezina added backport-to-stable and removed no-backport This should go to target branch only. branch: sssd-2-7 labels Sep 1, 2023
@pbrezina
Copy link
Member

pbrezina commented Sep 1, 2023

2.7 does not have system tests, lets use 2.8, 2.9 and master.

@pbrezina
Copy link
Member

pbrezina commented Sep 1, 2023

Pushed PR: #6717

  • master
    • 24a08ac - TESTS: Porting sss_override test suite
  • sssd-2-8
    • 0c73cdb - TESTS: Porting sss_override test suite
  • sssd-2-9
    • ee8f50f - TESTS: Porting sss_override test suite

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Sep 1, 2023
@pbrezina pbrezina closed this Sep 1, 2023
@danlavu danlavu deleted the local_overrides branch April 17, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoore1 spoore1 spoore1 approved these changes

@pbrezina pbrezina pbrezina approved these changes

Assignees

@spoore1 spoore1

@pbrezina pbrezina

Labels
branch: sssd-2-8 Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danlavu @pbrezina @spoore1