CONFDB: move sanity check

closer to a place where argument is really used Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Pavel Březina <[email protected]>
SSSD · Sep 5, 2024 · 604be8d · 604be8d
1 parent 50b4579
commit 604be8d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c
@@ -650,6 +650,11 @@ int confdb_init(TALLOC_CTX *mem_ctx,
     int ret = EOK;
     mode_t old_umask;
 
+    if (cdb_ctx == NULL) {
+        DEBUG(SSSDBG_FATAL_FAILURE, "Bad argument\n");
+        return EFAULT;
+    }
+
     cdb = talloc_zero(mem_ctx, struct confdb_ctx);
     if (!cdb)
         return ENOMEM;

diff --git a/src/tools/common/sss_tools.c b/src/tools/common/sss_tools.c
@@ -93,11 +93,6 @@ errno_t sss_tool_confdb_init(TALLOC_CTX *mem_ctx, struct confdb_ctx **_confdb)
     errno_t ret;
     struct stat statbuf;
 
-    if (_confdb == NULL) {
-        DEBUG(SSSDBG_FATAL_FAILURE, "Bad argument\n");
-        return EFAULT;
-    }
-
     ret = stat(path, &statbuf);
     if (ret != 0) {
         ret = errno;