feat: Implement get_package_version in hosts/base.py #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a heads up, this PR is related to SSSD/sssd#7597 and they should work together to detect features. While I find this PR generally fine, I have reservations about SSSD/sssd#7597. Rather than creating a separate test case for each feature, we could streamline with a single test and a table indicating feature presence or absence in each distribution version. |
spoore1
reviewed
Oct 22, 2024
jakub-vavra-cz
force-pushed
the
package_ver
branch
3 times, most recently
from
e4075ef
to
1dc2600
Compare
Find package version and parse it to major, minor, patch, pre-release, update release.
jakub-vavra-cz
force-pushed
the
package_ver
branch
from
1dc2600
to
fc37af9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find package version and parse it to major, minor, patch, release.
This is needed to detect sssd and ipa-client version to match expected features against versions and put workaround for RHEL 10 gating.