Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link errors calling Exception::getErrorCode() #96

Merged
merged 1 commit into from
Aug 5, 2016

Conversation

snej
Copy link
Contributor

@snej snej commented Aug 4, 2016

getErrorCode() and getExtendedErrorCode()'s implementations were
accidentally declared as inline in the .cpp file. This causes the
compiler to not generate any code for them, resulting in link errors
when a client calls them. (Observed compiling with Clang.)

Fixed by moving the implementations into the header, where they need to
be if they're inline.

getErrorCode() and getExtendedErrorCode()'s implementations were
accidentally declared as inline in the .cpp file. This causes the
compiler to not generate any code for them, resulting in link errors
when a client calls them.

Fixed by moving the implementations into the header, where they need to
be if they're inline.
@coveralls
Copy link

coveralls commented Aug 4, 2016

Coverage Status

Coverage decreased (-0.5%) to 96.984% when pulling 30e285f on couchbasedeps:master into 9d1ea82 on SRombauts:master.

@SRombauts SRombauts merged commit bfd8bb2 into SRombauts:master Aug 5, 2016
@SRombauts
Copy link
Owner

Thanks for this catch, I'll update unit-tests to cover these cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants