Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of SQLITECPP_USE_STATIC_RUNTIME #438

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

SRombauts
Copy link
Owner

@SRombauts SRombauts commented Aug 17, 2023

  • Replace the set() of "/MT" to REPLACE "/MD" "/MT" inspired from Zlib licensed glfw https://github.com/glfw/glfw/blob/master/CMakeLists.txt
  • Don't set SQLITECPP_USE_STATIC_RUNTIME by default when building with unit tests. Use gtest_force_shared_crt to force googletest to link against the default dynamic C++ runtime

Relates to #417

@SRombauts SRombauts self-assigned this Aug 17, 2023
@SRombauts SRombauts force-pushed the cmake-msvc-runtime-library branch from 658dbfc to 997c930 Compare August 17, 2023 14:46
@SRombauts SRombauts changed the title Update SQLITECPP_USE_STATIC_RUNTIME Update usage of SQLITECPP_USE_STATIC_RUNTIME Aug 17, 2023
…unit tests

Use gtest_force_shared_crt to force googletest to link against the default dynamic C++ runtime
@SRombauts SRombauts force-pushed the cmake-msvc-runtime-library branch from 997c930 to 2a43ce0 Compare August 18, 2023 13:49
@SRombauts SRombauts merged commit dfa4dd8 into master Aug 18, 2023
@SRombauts SRombauts deleted the cmake-msvc-runtime-library branch August 18, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant