Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect work of savepoint #390

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

spoyler
Copy link

@spoyler spoyler commented Dec 12, 2022

Add release for savepoint after rollabck in destructor for deleting it form sqlite transaction stack.

@SRombauts SRombauts self-assigned this Dec 12, 2022
@SRombauts SRombauts added the bug label Dec 12, 2022
@SRombauts
Copy link
Owner

Thanks for providing this :)

I think the main issue is that the old unit test didn't show that there was a bug, and now it doesn't prove either that the bug is fixed.
Could you add a test for that? It's not urgent but it would definitely help ensure it works as expected, and also show how it is expected to behave

@SRombauts SRombauts merged commit 343299a into SRombauts:master Dec 15, 2022
@SRombauts
Copy link
Owner

OK, I merged it without the unit tests.

I should rename the rollback() method to rollbackTo() now that I understand better the differences!

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants