Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other constants that work with sqlite3_open_v2 #305

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

LuAPi
Copy link
Contributor

@LuAPi LuAPi commented Oct 8, 2020

Add the other flags used in the open function to the SQLite namespace for convenience.

I added the ones that are ok to use with the sqlite3_open_v2 function described here https://www.sqlite.org/c3ref/open.html .
I didn't add the VFS only flags mentioned here https://www.sqlite.org/c3ref/c_open_autoproxy.html .

I also made sure the comments relating to threading mode used the "multi-thread" and "serialized" terminology used on this page https://www.sqlite.org/threadsafe.html for clarity.

I'm not sure if there was a reason these weren't included but the first thing I wanted to do was open the database in multi-thread mode and I found the flag was missing.

I've not really tested this beyond compiling it and opening a database with the SQLite::OPEN_NOMUTEX flag, but since this is just declaring some consts I expect the compiler is enough to check it's right.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 503afc3 on LuAPi:more-flags into adb7e7c on SRombauts:master.

@SRombauts SRombauts self-assigned this Nov 25, 2020
@SRombauts SRombauts merged commit e779e68 into SRombauts:master Jan 18, 2021
@SRombauts
Copy link
Owner

Thanks for your contribution, I don't know exactly how I didn't merge it when I first saw it, but now it's fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants