more cmake instructions for linux #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gocarlos, this kind of enhancement to documentation is always helpful! |
hextriclosan
reviewed
Oct 8, 2018
| SQLiteCpp | ||
| sqlite3 | ||
| pthread | ||
| dl |
There was a problem hiding this comment.
It's better to use cross-platform friendly ${CMAKE_DL_LIBS} and find_package(Threads REQUIRED) here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding only SQLiteCpp to target_link_libraries() was not enough for me under ubuntu 16.04.
there fore added cmake instructions in more detail.