-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tryExecuteStep and tryReset #142
Conversation
Great @kaptenhonek, thanks for your work on this! I'll have a look at your code, but could you provide a basic unit test so that the code coverage does not decrease? Cheers! |
Sure! |
Added tests (basically copied and adapted the test for executeStatement) |
… when statement needs to be reseted
Hi @kaptenhonek, thanks again. I've added two commits on (my copy of) your branch (see references above). It mainly uses mbDone to return a SQLITE_MISUSE as was done previously with exceptions. If it's okay for you, I'll merge it as is. |
Yeah, my initial commits was done quickly just to get things working, thanks for correcting the code :) |
You did perfectly find! I had to review the code, because it was getting too big/ugly, but this is just normal process. Thanks you again! |
Also, the merge-request has been closed automatically by the merge commit I pushed, AND the issue was closed since you referenced it in your first comment :) |
Awesome, thanks and good job :) |
fixes #121