Add install step #118
Merged
Add install step #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timrae
force-pushed
the
add-install-target
branch
from
cd5659b to
8387b59
Compare
|
Hi, thanks for this! |
|
Hey @timrae, could you please have a look of the issue with this "install" step I have just discovered? Cheers! |
|
Ok I'll try and take a look! |
|
Does the issue only occur with #111 or even without it? |
|
The error occurs only with #111 si I commented if out temporarily |
|
I think it's more usual for library users to link in both libraries, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, use of the library is quite cumbersome for us because it's lacking an install step.
This PR ensures that
make installworks correctly, and that users can reliably find it usingfind_packageaftermake installhas completed without any additional files or work.