SQLITE_ENABLE_JSON1 flag does not appear to compile sqlite3 with this option

[jcurtis-cc]

SQLiteCpp with the SQLITE_ENABLE_JSON1 #289 doesn't appear to be working. I'm using the following query to test, which returns zero.

SELECT sqlite_compileoption_used('ENABLE_JSON1')

I changed the line in ./build.sh to

cmake -DCMAKE_BUILD_TYPE=Debug -DSQLITE_ENABLE_JSON1=ON -DSQLITECPP_USE_ASAN=ON -DSQLITECPP_USE_GCOV=OFF -DSQLITECPP_BUILD_EXAMPLES=ON -DSQLITECPP_BUILD_TESTS=ON ..

And created a quick test in Database_test.cpp - which fails. for ease, you can pull it from my fork here

#ifdef SQLITE_ENABLE_JSON1
TEST(Database, json1)
{
    remove("test.db3");
    {
        // Create a new database
        SQLite::Database db("test.db3", SQLite::OPEN_READWRITE | SQLite::OPEN_CREATE);
        EXPECT_FALSE(db.tableExists("test"));
        EXPECT_EQ(1, db.exec("SELECT sqlite_compileoption_used('ENABLE_JSON1')"));
    } // Close DB test.db3
    remove("test.db3");
}
#endif // SQLITE_ENABLE_JSON1

Any thoughts? Perhaps I'm missing something obvious here.

[SRombauts]

Hello, can you provide more details on your setup? What OS? Aka is your project really recompiling the sqlite library or using an existing one from your distribution?

I am not in front of a computer so I cannot check the feature (coming from PR #288)

[jcurtis-cc]

Sure, MacOS 12.16 here

[SRombauts]

I think that's the reason, by default on Unixes CMake will detect the existing sqlite3 dynamic library installed in your system and use it
You want to use the cmake flag to force using the internal library built from source code

[SRombauts]

I know documentation is far from perfect, from the readme on troubleshooting:

or turn on the option(SQLITECPP_INTERNAL_SQLITE "Add the internal SQLite3 source to the project." ON) in CMakeFiles.txt

Let me know if you have any trouble with that

[jcurtis-cc]

option(SQLITECPP_INTERNAL_SQLITE "Add the internal SQLite3 source to the project." ON))

looks to be on by default this is also mentioned again here

perhaps something here is overriding this:

cmake -DCMAKE_BUILD_TYPE=Debug -DSQLITE_ENABLE_JSON1=ON -DSQLITECPP_USE_ASAN=ON -DSQLITECPP_USE_GCOV=OFF -DSQLITECPP_BUILD_EXAMPLES=ON -DSQLITECPP_BUILD_TESTS=ON ..

[SRombauts]

See PR #428 for the new branch I just pushed:
Remove option SQLITE_ENABLE_JSON1 since the JSON functions and operators are built into SQLite by default, as of SQLite version 3.38.0 (2022-02-22).

For us with SQLiteCpp it would be since Version 3.2.0 - 2022 September 18

• Updated SQLite3 from 3.32.3 to 3.33.0 (2020-08-14) #300 Update SQLite3 from 3.33.0 to 3.34.0 (2020-12-01) #316 Update SQLite from 3.37.2 to 3.39.2 from 2022-07-21 #362 Update SQLite from 3.39.2 to 3.39.3 (2022-09-05) #368 Updated SQLite3 from 3.32.3 to 3.39.3 (2022-09-05)

[SRombauts]

I hope this helps
Cheers!