Remove implementation of SRGImageMetadata for Program, as imageUrl is nullable. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable is nullable. SRGImageMetadata.imageUrl shouldn't be nullable as image url for other il objects is non null.
StaehliJ
reviewed
Apr 8, 2024
data/src/main/java/ch/srg/dataProvider/integrationlayer/data/remote/Program.kt
Show resolved
Hide resolved
StaehliJ
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Program.imageUrlcan be null, as defined in the swagger:If no imageUrl is set, Program items can't be parsed.
It occurs in RTS TV Guide 2024-04-05 for RTS. An item has no imageUrl.
Solution approach
Remove implementation of
SRGImageMetadataforProgram, asimageUrlis nullable.SRGImageMetadata.imageUrlshouldn't be nullable as image url for other il objects is non null.