Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove severity from monitoring error #757

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Remove severity from monitoring error #757

merged 1 commit into from
Oct 21, 2024

Conversation

MGaetan89
Copy link
Member

Pull request

Description

Remove the severity field from the monitoring Error message.

Changes made

  • Self-explanatory.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 linked an issue Oct 18, 2024 that may be closed by this pull request
Remove severity from Error monitoring messages #756
Closed
1 task
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 48.12% 🟢
Module Coverage
:pillarbox-player 57.44% 🟢
Files
Module File Coverage
:pillarbox-player Monitoring.kt 88.99% 🟢
ErrorMessageData.kt 43.33% 🟢

@MGaetan89 MGaetan89 added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Oct 21, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 21, 2024
@MGaetan89
Remove severity from monitoring error (#757)
51ea6a9
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 66b30d2 Oct 21, 2024
9 checks passed
@MGaetan89 MGaetan89 deleted the 756-remove-severity-from-error-monitoring-messages branch October 21, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove severity from Error monitoring messages
2 participants
@MGaetan89 @StaehliJ