Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the slider interactive again #733

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Make the slider interactive again #733

merged 1 commit into from
Oct 2, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Oct 1, 2024 •
edited
Loading

Pull request

Description

This PR makes the slider interactive again in ResizablePlayerShowcase and SmoothSeekingShowcase. The issue was introduced in #698, where interactionSource was made optional to follow Android's recommendation. However, these two usages were not updated to provide a non-null argument.

Fixes #722

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89
Make the slider interactive again
7fc29bb 
This PR makes the slider interactive again in `ResizablePlayerShowcase` and `SmoothSeekingShowcase`.
The issue was introduced in #698, where `interactionSource` was made optional to follow Android's recommendation.
However, these two usages were not updated to provide a non-`null` argument.

Fixes #722
@MGaetan89 MGaetan89 linked an issue Oct 1, 2024 that may be closed by this pull request
Broken seekbar in pillarbox-demo #722
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Code Coverage

Overall Project 48.84% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit bc04421 Oct 2, 2024
9 checks passed
@StaehliJ StaehliJ deleted the 722-broken-seekbar-in-pillarbox-demo branch October 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken seekbar in pillarbox-demo
2 participants
@MGaetan89 @StaehliJ