Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

519 simplify TimeRange management #521

Merged
merged 6 commits into from
May 2, 2024
Merged

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented May 1, 2024

Pull request

Description

The goal of this PR is to simplify TimeRange tracking by PillarboxPlayer.

Changes made

  • Remove internal classes that handled BlockedTimeRange and other TimeRange
  • Create one TimeRangeTracker that handle anything and simplify.
  • Asset is build with only one list of TimeRange, PillarboxData keeps seperate lists for each type of TimeRange.
  • SkipableTimeInterval is replaced by Credits.
  • TimeRange is a sealed interface.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue May 1, 2024 that may be closed by this pull request
1 task
@StaehliJ StaehliJ changed the title 519 simplify timerange management 519 simplify TimeRange management May 1, 2024
Copy link

github-actions bot commented May 1, 2024

Code Coverage

Overall Project 48.67% -1.38% 🟢
Files changed 68.4% 🟢

Module Coverage
:pillarbox-core-business 84.28% 🟢
:pillarbox-player 49.35% -2.65% 🟢
:pillarbox-ui 0% -0.62% 🟢
Files
Module File Coverage
:pillarbox-core-business ChapterAdapter.kt 100% 🟢
SegmentAdapter.kt 100% 🟢
TimeIntervalAdapter.kt 100% 🟢
SRGAssetLoader.kt 86.73% 🟢
:pillarbox-player PillarboxData.kt 100% 🟢
Asset.kt 100% 🟢
PillarboxSessionCommands.kt 100% 🟢
BlockedTimeRange.kt 100% 🟢
TimeRangeTracker.kt 92.76% -7.24% 🟢
PillarboxMediaSource.kt 91.92% 🟢
PillarboxExoPlayer.kt 78.61% -0.87% 🟢
TimeRange.kt 78.38% -5.41% 🟢
PlayerCallbackFlow.kt 71.7% -2.78% 🟢
Chapter.kt 55.56% -44.44% 🟢
Player.kt 31.96% -11.34% 🟢
PillarboxPlayer.kt 25% -25% 🟢
PillarboxMediaController.kt 0% -2.2% 🟢
PillarboxMediaSession.kt 0% -9.02% 🟢
Credit.kt 0% 🟢
:pillarbox-ui ComposablePlayer.kt 0% -3.44% 🟢

@MGaetan89 MGaetan89 force-pushed the 519-simplify-timerange-management branch from b1beacc to 5f53647 Compare May 1, 2024 13:44
@StaehliJ StaehliJ added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit f59e414 May 2, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 519-simplify-timerange-management branch May 2, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Simplify TimeRange management
2 participants