Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve controls usability in the TV demo #520

Merged
merged 4 commits into from
May 1, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented May 1, 2024

Pull request

Description

This PR improves the usability of the controls in the TV demo of Pillarbox.

Changes made

  • When pressing the enter button, the controls are displayed immediately.
  • When the controls are made visible, the play/pause state is no longer modified.
  • While navigating in/using the controls, they are no longer hidden automatically.
  • Refresh the design of the chapters.
  • Add transition when the current chapter changes.

New chapter design

Screenshot_20240501_112019

Chapter change animation

Screen_recording_20240501_112040.webm

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue May 1, 2024 that may be closed by this pull request
1 task
Copy link

github-actions bot commented May 1, 2024

Code Coverage

Overall Project 46.59% -0.2% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-ui 0% -0.77% 🟢
Files
Module File Coverage
:pillarbox-ui DelayedVisibilityState.kt 0% -4.61% 🟢

@MGaetan89 MGaetan89 added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 6a6588a May 1, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the 518-fix-control-usability-on-android-tv branch May 1, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Fix control usability on Android TV
2 participants