Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve media controller service #485

Merged
merged 28 commits into from
Apr 8, 2024
Merged

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Apr 4, 2024

Pull request

Description

The goal of this PR is to improve the usage of MediaSession and MediaController. It allows to have access to custom Pillarbox features when using MediaSession and MediaController.

Changes made

  • Add PillarboxPlayer interface for all kind of player in Pillarbox players.
  • AddPillarboxExoPlayer for ExoPlayer implementation.
  • Add PillarboxMediaController for MediaController implementation connected to a PillarboxMediaSession.
  • Add PillarboxMediaBrowser for MediaBrowser implementation connected to a PillarboxMediaLibrarySession.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Apr 5, 2024 that may be closed by this pull request
1 task
@StaehliJ StaehliJ force-pushed the improve-media-controller-service branch from b9992d8 to 175c50e Compare April 5, 2024 12:23
Copy link

github-actions bot commented Apr 5, 2024

Code Coverage

Overall Project 46.8% -17.26% 🟢
Files changed 17.52% 🟢

Module Coverage
:pillarbox-core-business 85.02% 🟢
:pillarbox-player 46.77% -40.03% 🟢
Files
Module File Coverage
:pillarbox-core-business DefaultPillarbox.kt 57.84% 🟢
:pillarbox-player PillarboxSessionCommands.kt 100% 🟢
PlayerSessionState.kt 100% 🟢
Player.kt 90.74% -9.26% 🟢
PillarboxExoPlayer.kt 77.16% -22.84% 🟢
PillarboxMediaLibrarySession.kt 0% 🟢
PillarboxMediaSessionService.kt 0% -53.66% 🟢
PillarboxMediaController.kt 0% 🟢
PillarboxMediaLibraryService.kt 0% -51.69% 🟢
PillarboxMediaBrowser.kt 0% 🟢
PillarboxMediaSession.kt 0% 🟢
PlaybackService.kt 0% 🟢
PillarboxPlayer.kt 0% 🟢

@StaehliJ StaehliJ force-pushed the improve-media-controller-service branch from bff58d2 to aa9eb75 Compare April 5, 2024 12:58
@StaehliJ StaehliJ requested a review from MGaetan89 April 8, 2024 06:59
@MGaetan89 MGaetan89 added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 9415056 Apr 8, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the improve-media-controller-service branch April 8, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve MediaController
2 participants