Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract analytics from CurrentMediaItemTracker #483

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Apr 4, 2024

Pull request

Description

This PR refactors CurrentMediaItemTracker to split the logic in two pieces:

  • CurrentMediaItemTagTracker which notifies when the current MediaItem's tag changes or when the current MediaItem is removed
  • AnalyticsMediaItemTracker which tracks when the current MediaItem starts or stops playing, or when it is replaced by a new MediaItem

Changes made

  • Split CurrentMediaItemTagTracker into two components
  • Update MediaItemTrackerList so its API is more similar to a Collection
  • Add new tests

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Apr 4, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Apr 4, 2024

Code Coverage

Overall Project 55.25% -0.05% 🟢
Files changed 86.67% 🟢

Module Coverage
:pillarbox-player 73.15% -0.16% 🟢
Files
Module File Coverage
:pillarbox-player AssetLoader.kt 100% 🟢
MediaItemTrackerList.kt 100% 🟢
CurrentMediaItemTracker.kt 95.51% 🟢
PillarboxPlayer.kt 68.89% -1.11% 🟢

@MGaetan89 MGaetan89 force-pushed the 480-make-currentmediaitemtracker-more-generic branch from 7b966b1 to 071d963 Compare April 4, 2024 15:04
@MGaetan89 MGaetan89 force-pushed the 480-make-currentmediaitemtracker-more-generic branch from 071d963 to 762aa2e Compare April 5, 2024 12:16
@StaehliJ StaehliJ added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit d9e96c2 Apr 5, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 480-make-currentmediaitemtracker-more-generic branch April 5, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Make CurrentMediaItemTracker more generic
2 participants