Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commanders act smooth seeking #456

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Feb 27, 2024

Pull request

Description

The goal of this PR is to modify CommandersAct event sent while smooth seeking and fixe an issue when playback reach EoF or has been stopped.

Changes made

  • Do not send any seek event when the player is paused.
  • Restart tracker when current item reset after playback stopped.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

Copy link

github-actions bot commented Feb 27, 2024

Code Coverage

Overall Project 45.93% -0.13% 🟢
Files changed 51.35% 🟢

Module Coverage
:pillarbox-core-business 66.52% -0.45% 🟢
:pillarbox-player 62.52% 🟢
Files
Module File Coverage
:pillarbox-core-business CommandersActStreaming.kt 71.99% -3.34% 🟢
:pillarbox-player CurrentMediaItemTracker.kt 91.74% 🟢

@StaehliJ StaehliJ added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit d72c345 Feb 29, 2024
9 checks passed
@StaehliJ StaehliJ deleted the fix-commanders-act-smooth-seeking branch February 29, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants