Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message #454

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Fix error message #454

merged 4 commits into from
Feb 23, 2024

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

The goal of this PR is to make test pass.

Changes made

  • Change the mp4 video that doesn't work on every machine.
  • Improve error message when media url fails.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 23, 2024 •
edited
Loading

Code Coverage

Overall Project 45.93% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-core-business 66.52% 🟢
Files
Module File Coverage
:pillarbox-core-business SRGErrorMessageProvider.kt 100% 🟢

@StaehliJ StaehliJ added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit cc7ecb5 Feb 23, 2024
9 checks passed
@StaehliJ StaehliJ deleted the fix-error-message branch February 23, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StaehliJ @MGaetan89