Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using DataProvider for business module #460

Open
1 task
StaehliJ opened this issue Feb 29, 2024 · 1 comment · Fixed by SRGSSR/srgdataprovider-android#41
Open
1 task

Using DataProvider for business module #460

StaehliJ opened this issue Feb 29, 2024 · 1 comment · Fixed by SRGSSR/srgdataprovider-android#41
Assignees
@MGaetan89
Labels
enhancement New feature or request

Comments

@StaehliJ
Copy link
Contributor

As a user / integrator I want to use official integration layer data.

Acceptance criteria

  • Use SRGDataProvider-Android:data module for parsing MediaComposition

Tasks

  • ...
@StaehliJ StaehliJ converted this from a draft issue Feb 29, 2024
@StaehliJ StaehliJ added this to the 2.0.0 milestone Mar 11, 2024
@MGaetan89 MGaetan89 removed this from the 2.0.0 milestone May 13, 2024
@MGaetan89 MGaetan89 added the enhancement New feature or request label May 15, 2024
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox May 15, 2024
@MGaetan89 MGaetan89 self-assigned this May 15, 2024
@MGaetan89 MGaetan89 mentioned this issue May 17, 2024
Merged
@MGaetan89 MGaetan89 linked a pull request May 17, 2024 that will close this issue
Add missing fields to Chapter and update TimeInterval SRGSSR/srgdataprovider-android#41
Merged
github-merge-queue bot pushed a commit to SRGSSR/srgdataprovider-android that referenced this issue May 21, 2024
@MGaetan89
Add missing fields to Chapter and update TimeInterval (#41)
b587321 
In the scope of SRGSSR/pillarbox-android#460,
we'd like to replace Pillarbox models of the integration layer objects
with those from data provider.

To do so, we need the following changes proposed in this PR:
- Add `fullLengthMarkIn` and `fullLengthMarkOut` to `Chapter`.
<img width="218" alt="Screenshot 2024-05-17 at 16 22 31"
src="https://github.com/SRGSSR/srgdataprovider-android/assets/1009664/ba08edff-2f0e-44fe-b70f-6973a600c785">

- Make `type`, `markIn`, and `markOut` nullable in `TimeInterval`.
<img width="302" alt="Screenshot 2024-05-17 at 16 22 52"
src="https://github.com/SRGSSR/srgdataprovider-android/assets/1009664/d6861f36-78e5-4839-b93d-5dd6654dc83a">

I've bump the library version to 0.10.0 since the changes in
`TimeInterval` could break if someone is using that class. Let me know
if I should use an other version.
github-merge-queue bot pushed a commit to SRGSSR/srgdataprovider-android that referenced this issue May 21, 2024
@MGaetan89
Add missing fields to Chapter and update TimeInterval (#41)
c29b53f 
In the scope of SRGSSR/pillarbox-android#460,
we'd like to replace Pillarbox models of the integration layer objects
with those from data provider.

To do so, we need the following changes proposed in this PR:
- Add `fullLengthMarkIn` and `fullLengthMarkOut` to `Chapter`.
<img width="218" alt="Screenshot 2024-05-17 at 16 22 31"
src="https://github.com/SRGSSR/srgdataprovider-android/assets/1009664/ba08edff-2f0e-44fe-b70f-6973a600c785">

- Make `type`, `markIn`, and `markOut` nullable in `TimeInterval`.
<img width="302" alt="Screenshot 2024-05-17 at 16 22 52"
src="https://github.com/SRGSSR/srgdataprovider-android/assets/1009664/d6861f36-78e5-4839-b93d-5dd6654dc83a">

I've bump the library version to 0.10.0 since the changes in
`TimeInterval` could break if someone is using that class. Let me know
if I should use an other version.
@github-project-automation github-project-automation bot moved this from 🚧 In Progress to ✅ Done in Pillarbox May 21, 2024
@MGaetan89 MGaetan89 moved this from ✅ Done to 🚧 In Progress in Pillarbox May 21, 2024
@MGaetan89
Copy link
Member

Reopening, since there is also some work to do in pillarbox-android

@MGaetan89 MGaetan89 reopened this May 21, 2024
@github-project-automation github-project-automation bot moved this from 🚧 In Progress to 📋 Backlog in Pillarbox May 21, 2024
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox May 21, 2024
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 📋 Backlog in Pillarbox May 24, 2024
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MGaetan89 MGaetan89

Labels
enhancement New feature or request
Projects
Pillarbox
Status: 📋 Backlog
Milestone
No milestone
2 participants
@MGaetan89 @StaehliJ