Linux/MacOS Installations Script Updated #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AryanNanda17
changed the title
AryanNanda17
changed the title
|
@SuperChamp234, Please review the pr and why did the tests failed? |
@SuperChamp234, Gentle Reminder! |
SuperChamp234
requested changes
Aug 18, 2024
| @@ -1,34 +1,19 @@ | |||
| #!/usr/bin/env bash | |||
| set -e | |||
| export DEBIAN_FRONTEND=noninteractive | ||
| _sudo apt update && _sudo apt upgrade -y | ||
| _sudo apt install git wget flex bison gperf python3 python3-pip python3-setuptools cmake ninja-build ccache libffi-dev libssl-dev dfu-util libusb-1.0-0 -y | ||
| sudo apt update && sudo apt upgrade -y |
There was a problem hiding this comment.
So, when you removed the _sudo function, this will ask for password here. The script is supposed to run without interruptions once started, so why remove the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Wall-E Installations Script for Linux/MacOS.