Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More details for Execution Context usage #92

Closed
wants to merge 1 commit into from

Conversation

apitukh
Copy link

@apitukh apitukh commented Sep 12, 2024

Minor changes according to previous discussions:

@apitukh apitukh requested a review from a team as a code owner September 12, 2024 14:09
@apitukh
Copy link
Author

apitukh commented Sep 16, 2024

Watched the last recording about 400/404 responses (REDACTED) See 18:38 to 32:27 . As I understand there wasn't a decision to use 400 in all cases. It was discussed, that it might be 400 in Lookup Store, but 404 in ODO Bridge. Also, there was a discussion between using 400 for Search endpoints and 404 for get-by-id endpoints (GET, PUT, PATCH?).

@travisgosselin
Copy link
Member

@apitukh - please be advised this is an open source repo, I have redacted your comment to remove noted recordings / passwords, etc.

@travisgosselin
Copy link
Member

After reviewing, I'm not clear if this nuance needs to be represented in the API Standards, or if this is a reflection of the behavior being added for some of those internal APIs.

@travisgosselin travisgosselin self-assigned this Sep 16, 2024
@travisgosselin travisgosselin marked this pull request as draft September 16, 2024 17:55
@travisgosselin travisgosselin added the clarification Clarity on API Standards was needed (no changes). label Sep 16, 2024
@travisgosselin
Copy link
Member

Going to close this for now and instead we can open up further discussion if this is actually a broader API Standard we want to discuss first to gain alignment.

@travisgosselin travisgosselin deleted the enh/execution-context-400 branch September 16, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Clarity on API Standards was needed (no changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants