Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes manifest #3

Merged
merged 9 commits into from
Sep 8, 2022
Merged

Fix kubernetes manifest #3

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
47a7f6a
change the kubernetes_manifest resource
uchinda-sph Sep 6, 2022
c536bbd
fix the output
uchinda-sph Sep 6, 2022
5713bf0
hardcode the value of affinity and tolerents
uchinda-sph Sep 6, 2022
d6bc6a0
fix resource manifest
uchinda-sph Sep 6, 2022
2b11324
change the name
uchinda-sph Sep 6, 2022
8e136c0
uncomment the manifest
uchinda-sph Sep 6, 2022
a3e0621
clean up the code
uchinda-sph Sep 6, 2022
1fc47b3
move from kubernetes_manifest to kubectl_manifest
uchinda-sph Sep 8, 2022
dba6308
adding implicit dependency
uchinda-sph Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions org_runners.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
resource "kubernetes_manifest" "github_org_runners" {
for_each = { for org in var.github_org_runners : org.name => org }
depends_on = [helm_release.release]
for_each = { for org in var.github_org_runners : org.name => org }

manifest = {
apiVersion = "actions.summerwind.dev/v1alpha1"
kind = "RunnerDeployment"

metadata = {
name = "${lower(each.value.name)}-runner-deployment"
namespace = var.chart_namespace
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we stick with this and change this to

namespace = helm_release.namespace

?

Then there will be an implicit dependency.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it should work let me test it, Thanks

namespace = helm_release.release.namespace
}

spec = {
Expand Down