Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gate "SubnetsClusterTagCheck" to disable subnet cluster tag check #3

Merged
merged 7 commits into from
Sep 29, 2022

Conversation

franklinpashok
Copy link

No description provided.

Copy link

@lawliet89 lawliet89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump chart to 1.4.4 and image version to 2.4.3 pls.

README.md Outdated
@@ -104,3 +104,103 @@ to a Kubernetes Cluster.
| <a name="output_iam_role_name"></a> [iam\_role\_name](#output\_iam\_role\_name) | Name of IAM role |
| <a name="output_iam_role_path"></a> [iam\_role\_path](#output\_iam\_role\_path) | Path of IAM role |
| <a name="output_iam_role_unique_id"></a> [iam\_role\_unique\_id](#output\_iam\_role\_unique\_id) | Unique ID of IAM role |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete the ones above? They are repeated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README still has duplicate tf-docs generated stuff @franklinpashok

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the duplicates in readme. yes the tf-docs if run after deleting it updated again. Now fixed

@franklinpashok franklinpashok merged commit 148a434 into master Sep 29, 2022
@franklinpashok franklinpashok deleted the feature-gate branch September 29, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants