Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5 collective output #853

Merged
merged 21 commits into from
Nov 5, 2024
Merged

HDF5 collective output #853

merged 21 commits into from
Nov 5, 2024

Conversation

mnagaso
Copy link

@mnagaso mnagaso commented Nov 5, 2024

Hi @danielpeter ,

I am now implementing

  • HDF5 I/O and
  • IO server

on Specfem3D_globe as well. This merge request is for the first part (HDF5 I/O). I am working on IO server part in another branch in order to separate the merge requests for those two new functions.

I was carefully following your refactored implementation on Specfem3d Cartesian ver. but excuse me if there is any error.

Thank you always for your hard efforts on maintaining our important tools.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 12.18130% with 310 lines in your changes missing coverage. Please review.

Project coverage is 33.23%. Comparing base (e6e7b25) to head (794973b).
Report is 22 commits behind head on devel.

Files with missing lines Patch % Lines
src/specfem3D/write_movie_volume_hdf5.F90 0.00% 36 Missing ⚠️
src/specfem3D/save_kernels_hdf5.F90 0.00% 35 Missing ⚠️
src/specfem3D/read_arrays_solver_hdf5.F90 0.00% 31 Missing ⚠️
src/specfem3D/write_movie_output.f90 0.00% 28 Missing ⚠️
src/meshfem3D/save_arrays_solver_hdf5.F90 0.00% 20 Missing ⚠️
src/specfem3D/save_forward_arrays_hdf5.F90 0.00% 20 Missing ⚠️
src/specfem3D/read_mesh_databases.F90 30.76% 18 Missing ⚠️
src/specfem3D/write_movie_surface_hdf5.F90 0.00% 16 Missing ⚠️
src/specfem3D/read_forward_arrays_hdf5.F90 0.00% 15 Missing ⚠️
src/specfem3D/write_output_HDF5.F90 0.00% 12 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #853      +/-   ##
==========================================
- Coverage   35.59%   33.23%   -2.37%     
==========================================
  Files         284      294      +10     
  Lines       67727    67976     +249     
==========================================
- Hits        24110    22589    -1521     
- Misses      43617    45387    +1770     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeter
Copy link
Contributor

looks great, thanks Masaru-san!

as a tip, try to turn on github actions also on your fork repository (in your repo's settings). that way you could check first with your own fork repo if the tests would run through successfully.

@danielpeter danielpeter merged commit 1a978a5 into SPECFEM:devel Nov 5, 2024
26 of 29 checks passed
@mnagaso
Copy link
Author

mnagaso commented Nov 5, 2024

Thank you very much Daniel!
And I'm sorry for consuming your cpu time for the CI workflow. Yes I will do it on my side from the next request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants