-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDF5 collective output #853
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #853 +/- ##
==========================================
- Coverage 35.59% 33.23% -2.37%
==========================================
Files 284 294 +10
Lines 67727 67976 +249
==========================================
- Hits 24110 22589 -1521
- Misses 43617 45387 +1770 ☔ View full report in Codecov by Sentry. |
looks great, thanks Masaru-san! as a tip, try to turn on github actions also on your fork repository (in your repo's settings). that way you could check first with your own fork repo if the tests would run through successfully. |
Thank you very much Daniel! |
Hi @danielpeter ,
I am now implementing
on Specfem3D_globe as well. This merge request is for the first part (HDF5 I/O). I am working on IO server part in another branch in order to separate the merge requests for those two new functions.
I was carefully following your refactored implementation on Specfem3d Cartesian ver. but excuse me if there is any error.
Thank you always for your hard efforts on maintaining our important tools.