Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.9.0 #419

Closed
enridaga opened this issue Nov 6, 2023 · 17 comments
Closed

Release v0.9.0 #419

enridaga opened this issue Nov 6, 2023 · 17 comments

Comments

@enridaga
Copy link
Member

enridaga commented Nov 6, 2023

There are 49 issues closed mapped to this release milestone (!):

https://github.com/SPARQL-Anything/sparql.anything/issues?q=is%3Aopen+is%3Aissue+milestone%3Av0.9.0

A bunch are still open, mostly documentation and minor things, except for the caching (#371 / #372).

I think we should move to a release soon, in case, postponing the remaining large chunks of work to a future release.

@luigi-asprino
Copy link
Member

Hi @enridaga,

maybe it is time to release the 0.9.0? So we can also test the maven workflow (#153). Can we tag it as 0.9.0 (without the v prefix). The tag name is used as the artefact id on Maven Central and I suppose that the "v" prefix makes the workflow fail.

@enridaga
Copy link
Member Author

enridaga commented Nov 29, 2023

Sure, can we start from RCs, e.g. 0.9.0-RC1?

When we are happy, we can trigger the official release closing milestone 0.9.0 (I suppose we need to rename it first).

@luigi-asprino
Copy link
Member

tag names can be renamed? if not, maybe an additional release is needed. I don't know how central repository react to -RC suffix

@enridaga
Copy link
Member Author

I tried to create a release but the maven repo action failed, something about the gpg key: https://github.com/SPARQL-Anything/sparql.anything/actions/runs/7037712169/job/19153082603

@luigi-asprino
Copy link
Member

luigi-asprino commented Nov 30, 2023

I've already had this error before, the process is running out of time, but I couldn't find out why.
If you google it, you get that this is caused by a server error, but I'm not sold on this (why snapshot artefacts are accepted instead?)

@enridaga
Copy link
Member Author

enridaga commented Dec 1, 2023

I've already had this error before, the process is running out of time, but I couldn't find out why. If you google it, you get that this is caused by a server error, but I'm not sold on this (why snapshot artefacts are accepted instead?)

Can try to deploy a 0.9.0-alpha-1 from your laptop? Just to see if you can reproduce the error... we need to test the deployment on mc before we release.

@luigi-asprino
Copy link
Member

luigi-asprino commented Dec 1, 2023

Same error on my laptop, but I may have found the problem.
The public key has not been uploaded to the keys.openpgp.org key server.
Strange, but I uploaded it, and the deployment was completed successfully.
If all went well, the artefacts should be indexed in the central repository within a few hours.
The artefact uploaded from my laptop has a version id of 0.9.0-alpha-1.
I re-run the workflow from github, and it completed too (the id is 0.9.0-RC-2).

@luigi-asprino
Copy link
Member

Both are available on maven central!! https://central.sonatype.com/search?namespace=io.github.sparql-anything

@enridaga
Copy link
Member Author

enridaga commented Dec 5, 2023

@luigi-asprino can we then remove #371 and #372 from the milestone, then? I can draft the release closing the milestone etc...

@luigi-asprino
Copy link
Member

yes, I postponed the issues to the next milestone. Please go ahead with the closing.

@enridaga
Copy link
Member Author

enridaga commented Dec 5, 2023

What about #429 ?

@luigi-asprino
Copy link
Member

The first milestone (i.e., allowing query pptx) has been reached. There are some additional requirements to fulfil but for those, I opened #435 and #436. I couldn't look into the problem @kvistgaard was reporting. Maybe, we can leave the #429 open and postpone it to the next milestone too.

@enridaga
Copy link
Member Author

enridaga commented Dec 6, 2023

OK, the auto-release action is failing us: ecampidoglio/auto-release-milestone#4

Will see if we can recover, otherwise we'll do without fancy detailed release notes.

@enridaga
Copy link
Member Author

enridaga commented Dec 7, 2023

I moved the action to a repo managed by myself and it is how working, except it breaks on some issue types. Cleaning up labels should do the job. The referenced action is now here: https://github.com/enridaga/auto-release-milestone

@enridaga
Copy link
Member Author

enridaga commented Dec 7, 2023

Issues labeled as "Management" break the auto-release. We can remove the from the milestone now. in the future, we need to find a way to customise the labels that the action supports.

@enridaga
Copy link
Member Author

enridaga commented Dec 7, 2023

Maven action needs to be triggered on published, not created (otherwise the audo-draft plugin process does not trigger it).

@enridaga
Copy link
Member Author

enridaga commented Dec 7, 2023

After a few failed attempts, we now have a release published both on docker and maven central.

@enridaga enridaga closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants