Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Q-gram distance #394

Closed
EmidioStani opened this issue Jul 10, 2023 · 2 comments
Closed

Support for Q-gram distance #394

EmidioStani opened this issue Jul 10, 2023 · 2 comments
Labels
Feature New feature or request
Milestone

Comments

@EmidioStani
Copy link
Contributor

Hello,

it would be interesting for me to support Q-gram distance.

By looking at the code I see you support those distances from Apache Commons.

I noticed that the java-string-similarity supports such distance (and others), released under MIT license and provided through Maven.

Would it be possible to include it ?

Thanks,

Emidio

@enridaga
Copy link
Member

Hi Emilio, sure, it makes a lot of sense a nice extension to the function list.

The process should be easy as adding the dependency and wiring the function using the reflection library we developed. This can be done in different ways, see

@enridaga enridaga added this to the v0.9.0 milestone Jul 14, 2023
@luigi-asprino luigi-asprino added the Feature New feature or request label Jul 14, 2023
luigi-asprino added a commit that referenced this issue Nov 3, 2023
Include QGram distance (see #394)
luigi-asprino added a commit that referenced this issue Nov 3, 2023
Document QGram distance (see #394)
@luigi-asprino
Copy link
Member

2c5d286 introduces the function fx:QGramDistance(?n1, ?n2) for computing the QGram Distance between two strings.

The implementation of the algorithm is provided by the java-string-similarity library (I couldn't find the implementation on the apache commons).

579aef7 adds the documentation of the fx:QGramDistance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants