Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Clarify json.path in docs #333

Closed
justin2004 opened this issue Jan 24, 2023 · 3 comments
Closed

[Documentation] Clarify json.path in docs #333

justin2004 opened this issue Jan 24, 2023 · 3 comments
Labels
Documentation Improvements or additions to documentation
Milestone

Comments

@justin2004
Copy link
Contributor

in the json docs:
https://github.com/SPARQL-Anything/sparql.anything/blob/v0.9-DEV/formats/JSON.md

we mostly talk about using json.path and i think that misleads users into thinking that they should use it to remodel their data into RDF.
see #332

i wonder if we should use the example in #332 as the first example and only at the bottom demonstrate json.path (which i hardly ever use)?

@enridaga
Copy link
Member

Agreed 100% - the json.path option is so misleading that I almost regret it 😆

enridaga added a commit that referenced this issue Jan 31, 2023
enridaga added a commit that referenced this issue Jan 31, 2023
@enridaga
Copy link
Member

i wonder if we should use the example in #332 as the first example and only at the bottom demonstrate json.path (which i hardly ever use)?

I added two examples without json.path, including yours.

@enridaga enridaga added this to the v0.9.0 milestone Jan 31, 2023
@enridaga enridaga changed the title json.path in docs [Documentation] Clarify json.path in docs Jan 31, 2023
@enridaga enridaga added the Documentation Improvements or additions to documentation label Jul 14, 2023
@enridaga
Copy link
Member

enridaga commented Nov 7, 2023

This seems to be addressed.

@enridaga enridaga closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants