Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown tests fail on windows due to line ending different from unix one #309

Closed
luigi-asprino opened this issue Sep 25, 2022 · 2 comments

Comments

@luigi-asprino
Copy link
Member

This relates to #266
DOS line ending is \r\n while Unix is \n

https://www.cs.toronto.edu/~krueger/csc209h/tut/line-endings.html#:~:text=Text%20files%20created%20on%20DOS,(%22%5Cn%22).

Therefore, the expected graph contains \r\n as line-ending and the graph generated on windows has just \n.

@luigi-asprino
Copy link
Member Author

On my mac (and on the remote repository I suppose) the input files of the tests contain only line feed characters (\n).
But, after pulling the files on windows, the line ending becomes \r\n.
Therefore, I thought that there must be something in git to control how the line endings are handled.
I found that this can be controlled via .gitattributes file https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings
With f555808 I added a .gitattributes file which forces (I hope) the files of the repository to be pulled with \n as line ending character.

@luigi-asprino
Copy link
Member Author

I cloned the repository from scratch on windows.
I re-run the tests in the markdown module which seem to be working.
I'm going to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant