IT tests failing after executor refactoring

[enridaga]

As the summary says

[enridaga]

Apparently, after using the ondisk option, subsequent tests are failing. I isolated testIssue280 and testIssue284. 284 runs smoothly if executed alone. The test class we are focusing on now is IssuesTest2

[luigi-asprino]

the BaseFacadeXGraphBuilder uses static fields

sparql.anything/sparql-anything-model/src/main/java/com/github/sparqlanything/model/BaseFacadeXGraphBuilder.java

Line 42 in 70c402a

protected static Dataset dataset = null; // TODO making this static is a kludge maybe

maybe the problem depends on this?

[luigi-asprino]

This

sparql.anything/sparql-anything-model/src/main/java/com/github/sparqlanything/model/BaseFacadeXGraphBuilder.java

Line 58 in 70c402a

if(BaseFacadeXGraphBuilder.previousTDB2Path != "" && ONDISK_REUSE){

Shouldn't it be !BaseFacadeXGraphBuilder.previousTDB2Path.equals("")?

[luigi-asprino]

This 8c6de26 removes the static fields from the class BaseFxGraphBuilder.
Tests in IssuesTest2 don't fail anymore

[luigi-asprino]

We can close this issue if there are no other tests failing.

[luigi-asprino]

I close this issue as it is completed via f1355c0