[FEAT/#95] 채팅 관련 정보 조회 API 연결 #107
Merged
+400
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonjeen
approved these changes
Jan 22, 2025
| import javax.inject.Inject | ||
|
|
||
| class ChatDataSource @Inject constructor( | ||
| private val service: ChatService |
Comment on lines
8
to
13
| @SerialName("nickname") val nickname: String, | ||
| @SerialName("firstPhoto") val firstPhoto: String, | ||
| @SerialName("tradeType") val tradeType: String, | ||
| @SerialName("title") val title: String, | ||
| @SerialName("price") val price: Int, | ||
| @SerialName("isPriceNegotiable") val isPriceNegotiable: Boolean, |
There was a problem hiding this comment.
p1: 개행해주세요~
Suggested change
| @SerialName("nickname") val nickname: String, | |
| @SerialName("firstPhoto") val firstPhoto: String, | |
| @SerialName("tradeType") val tradeType: String, | |
| @SerialName("title") val title: String, | |
| @SerialName("price") val price: Int, | |
| @SerialName("isPriceNegotiable") val isPriceNegotiable: Boolean, | |
| @SerialName("nickname") | |
| val nickname: String, | |
| @SerialName("firstPhoto") | |
| val firstPhoto: String, | |
| @SerialName("tradeType") | |
| val tradeType: String, | |
| @SerialName("title") | |
| val title: String, | |
| @SerialName("price") | |
| val price: Int, | |
| @SerialName("isPriceNegotiable") | |
| val isPriceNegotiable: Boolean, |
| import javax.inject.Inject | ||
|
|
||
| class ChatRepositoryImpl @Inject constructor( | ||
| private val dataSource: ChatDataSource |
| tradeType = uiState.tradeType, | ||
| title = uiState.title, | ||
| firstPhoto = uiState.firstPhoto, | ||
| price = "${uiState.price.toString().formatToPriceString()}원", |
| onNavigateUp: () -> Unit, | ||
| ) { | ||
| composable<DetailPage> { | ||
| composable<DetailPage> { backStackEntry -> | ||
| val productId = backStackEntry.arguments?.getLong("productId") ?: 0L |
There was a problem hiding this comment.
productId가 없거나 잘못된 데이터를 전달한 경우에도 앱이 튕기면서 꺼지는 경우를 대비해서 넣었습니다! 오류나면서 꺼지는 것보다 기본값 나오는 게 나을 것 같아서 적용했는데 수정할까욤??
boiledEgg-s
approved these changes
Jan 22, 2025
| @Binds | ||
| @Singleton | ||
| abstract fun bindChatRepository( | ||
| impl: ChatRepositoryImpl, |
There was a problem hiding this comment.
p1: 이름 컨벤션 => chatRepositoryImpl
Comment on lines
13
to
19
| val response = dataSource.getChatInfo(productId) | ||
| if (response.status == 200) { | ||
| response.data.toDomain() | ||
| } else { | ||
| throw IllegalStateException("Error fetching chat info: ${response.message}") | ||
| } | ||
| } |
There was a problem hiding this comment.
p1: 예전 리뷰에서도 언급한 적 있는 것 같은데, dataSource의 함수를 호출했을 때 오류가 발생하면 runCatching에서 자동으로 failure 처리를 합니다! 따라서 다음과 같이 수정해도 별탈 없이 코드가 수행됩니다
Suggested change
| val response = dataSource.getChatInfo(productId) | |
| if (response.status == 200) { | |
| response.data.toDomain() | |
| } else { | |
| throw IllegalStateException("Error fetching chat info: ${response.message}") | |
| } | |
| } | |
| val response = dataSource.getChatInfo(productId) | |
| response.data.toDomain() | |
jm991014
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
1.mp4
2, 구해요
2.mp4
To Reviewers 📢
채팅 관련 정보 조회 했습니다!