Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Celestica]: Add support for Blackstone platform #262

Merged

Conversation

mudsut4ke
Copy link

@mudsut4ke mudsut4ke commented Oct 7, 2021

- What I did

  • Added Support for Celestica Blackstone platform

- How I did it

  • Add Blackstone device "x86_64-cel_blackstone-r0"
  • Add Blackstone platform and device installer script to sonic-platform-modules-cel
  • Implemented the support for Blackstone platform
    • SYS CPLD Driver
    • MISC CPLD Driver
    • FPGA Driver
    • TLV-EEPROM Driver
  • Implemented the support for Blackstone device ( x86_64-cel_blackstone-r0 )
    • sensors config
    • eeprom plugin
    • psu plugin

- How to verify it

  • Use getreg/setreg sysfs to test CPLD/FPGA register access
  • Use the cli "decode-syseeprom" to test the eeprom plugin.
  • Use the "psuutil" cli to test the psu plugin.
  • Use the "sensors" cli to test the sensor configuration.

- Note

  • Current version 0.1
  • TBD on version 0.2
    • sfputil plugin
    • Platform APIs
      • chassis api
      • platform api
      • device api
    • QSFP/SFP Driver
    • LED Driver

Wirut Getbamrung and others added 30 commits September 14, 2021 12:52
…v-switch-driver

[device/celestica-blackstone]: Update switch CPLD driver follow FPGA i2c buses
@mudsut4ke mudsut4ke self-assigned this Oct 8, 2021
Wirut Getbamrung added 2 commits October 27, 2021 15:07
* [platform/cel-blackstone]: update misc_cpld device name

* [platform/cel-blackstone]: update misc_cpld driver version

* [platform/cel-blackstone]: update misc_cpld init command
* [platform/cel-blackstone]: update FPGA driver to support BMC I2C

* [platform/cel-blackstone]: update i2c devices driver init command
Copy link
Collaborator

@pphuchar pphuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented.
If possible, please apply Linux kernel codes style to the source files under blackstone/modules/ path.

static void fpga_pci_remove(void)
{
iounmap(fpga_dev.data_base_addr);
// class_unregister(fpgafwclass);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this unused codes be removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove next release


if (dev){
err = fpga_pci_probe(dev);
// pci_dev_put(dev);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove next release

@@ -0,0 +1,846 @@
// SPDX-License-Identifier: GPL-2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we using the ocores-i2c from the kernel source tree, could this module and the i2c-ocores.h be removed from the platform-specific path?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove next release

Wirut Getbamrung added 2 commits November 5, 2021 15:22
* [device/celestica-blackstone]: update necessary chassis apis

* [platform/cel-blackstone]: add platform api installer

* [platform/cel]: update missing apis installer command

* [device/celestica-blackstone]: update sfputil follow hw spec

* [device/celestica-blackstone]: update skip_syseepromd config for pmon
* [device/celestica-blackstone]: update necessary chassis apis

* [platform/cel-blackstone]: add platform api installer

* [platform/cel]: update missing apis installer command

* [device/celestica-blackstone]: update sfputil follow hw spec

* [device/celestica-blackstone]: update skip_syseepromd config for pmon

* [platform/cel]: update api installer script
@mudsut4ke mudsut4ke merged commit 068094d into SONIC-DEV:202012_Blackstone Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants