Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic #invokeOn:with: test #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add basic #invokeOn:with: test #85

wants to merge 1 commit into from

Conversation

smarr
Copy link
Member

@smarr smarr commented Dec 5, 2021

There was no usage of #invokeOn:with: yet in the code base, so, here a very minimal test.

@smarr smarr added the enhancement Improves the implementation with something noteworthy label Dec 5, 2021
@smarr
Copy link
Member Author

smarr commented Dec 5, 2021

Hmpf. Only TruffleSOM even implements the primitive as it seems...

@smarr smarr mentioned this pull request Dec 5, 2021
Merged
@Hirevo
Copy link

Hirevo commented Dec 5, 2021

SOM-rs also implements the primitive.
I ran the new test code in the REPL and it gives me the correct outputs.
The test failure seems to indicate that it is something else that evaluated incorrectly, I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improves the implementation with something noteworthy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarr @Hirevo