At primitive implementation for String>>#charAt: #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this seems correct to me, but I didn’t actually check it… Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a good speedup in the interpreters for Json, the only benchmark using it.
The bytecode JIT startup seems to suffer unfortunately. I assume it's some odd interaction.
BC JIT steady performance also improves quite a bit.
The AST JIT is not bothered, neither for startup nor steady performance.
https://rebench.dev/RPySOM/compare/470bab233c9f2bc9f97362be394b298301f66ecc..d93c8ba6588b2a5d3d81ef40d16a000840f83cca
The PR also adds the diagram describing the inner frame, from the AST interpreter to the BC one. I am pretty sure its correct, but didn't check... I know, future me will hate this...