Various improvements to dynamic backend loading #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show the exact library name in the error message to give the users a fighting chance to figure what's going on. Also report the extra search path, which can be useful as well.
Don't show just "." in the error message, this is not really useful.
By default, i.e. if the application doesn't call ::SetErrorMode() itself, any failure inside LoadLibrary() shows error message boxes that are unexpected and not useful, as we're prepared to handle the errors ourselves. Disable these message boxes for the duration of do_register_backend() execution.
Using "handler" instead of "handle" was confusing, so rename the type and also the name of the variable using it. No real changes.
No real changes, just a bit of hygiene.
In the future we should get rid of this code completely and just use std::mutex, but this commit just makes things a bit less ugly without changing anything else.
This seems preferable to loading them from the current directory, which we did until now. The backends load path can still be overridden by defining SOCI_BACKENDS_PATH environment variable at run-time or appended to by defining DEFAULT_BACKENDS_PATH at build time.
Don't do it eagerly on the program startup, the application may end up not opening any databases at all, so wait until we actually need them.
Use return value of std::map::erase() now that we do use C++11. No real changes, just simplify the code a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error messages and the default path for loading, especially under Unix, where
dlopen()doesn't look into the directory containing the loading module by default.