Add TLS support to Kafka #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimEvens
reviewed
Oct 25, 2017
| topic_names_map[it->first.as<std::string>()] = it->second.as<std::string>(); | ||
| } | ||
| } else if (debug_general) | ||
| if (topic_names_map.find(it->first.as<std::string>()) != topic_names_map.end()) |
There was a problem hiding this comment.
I don't believe you intended to change this. This can happen if your fork isn't up-to-date with the master. In order to maintain your fork, you need to periodically sync it to the master/upstream. See this link for details on how to do that: https://help.github.com/articles/syncing-a-fork/
For now, I can fix this on merge.
|
I'll merge this soon.. Just will run a couple tests. |
|
Is it possible to implement kafka client authentication? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.