Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import cross sections from csv #41
base: master
Are you sure you want to change the base?
Import cross sections from csv #41
Changes from 15 commits
0a0270c
d5c8552
553738f
5300d62
dab091b
d69d61b
7984c15
66b1c6f
4fdafa7
dca2d49
eb079f6
8190183
946efaa
cd0f3c0
8f48e5e
a959150
067c289
a621ab0
13911d0
4fb993d
cd4dc0e
5c9c31c
b138c4b
bb8a526
5cdb67b
39651d5
a2441b5
f59b50a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use descriptive names for variables. It is hard to read a line of code operating on
a
,b
,c
, andd
and understand what it is supposed to be doing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new name
data_string
is a bit better because it is at least "greppable". But it's also a bit misleading becausedata_string
is not actually a string, it's a list. Maybe something likedata_lines
would be better, as this conveys how it was split?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data_strings
would at least be better. If you readdata_string[0]
it looks like it indexes a single letter from a string. Whereasdata_strings[0]
clearly gets a longer string, which can be split.