Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sqlserver to 2022 in CI to fix startup crash #1940

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

rkm
Copy link
Member

@rkm rkm commented Sep 19, 2024

Proposed Changes

Seems that mcr.microsoft.com/mssql/server:2017-latest no longer works on the Ubuntu CI runner. Possibly the same issue as microsoft/mssql-docker#899.

This bumps the image to 2022-latest and fixes related issues.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

@rkm rkm changed the title docker-compose -> docker compose bump sqlserver to 2022 in CI to fix startup crash Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (86a4ae1) to head (abefc7e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1940   +/-   ##
=======================================
  Coverage   64.09%   64.09%           
=======================================
  Files         177      177           
  Lines        6529     6529           
  Branches      969      969           
=======================================
  Hits         4185     4185           
  Misses       2057     2057           
  Partials      287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm marked this pull request as ready for review September 19, 2024 10:43
@rkm rkm enabled auto-merge September 19, 2024 10:43
@rkm rkm requested a review from a team September 19, 2024 10:43
@rkm rkm mentioned this pull request Sep 19, 2024
11 tasks
@rkm rkm merged commit 830c1c7 into main Sep 19, 2024
19 checks passed
@rkm rkm deleted the fix/ci-containers branch September 19, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants