code refactor

SKHUMING · Sep 27, 2023 · b77a929 · b77a929
1 parent d7b8797
commit b77a929
Showing 1 changed file with 8 additions and 15 deletions.
diff --git a/src/main/java/com/itcontest/skhuming/ranking/application/RankingService.java b/src/main/java/com/itcontest/skhuming/ranking/application/RankingService.java
@@ -32,22 +32,15 @@ public MemberRankResDto memberRakingInformation(Long memberId, int departmentNum
 
         Member member = memberRepository.findById(memberId).orElseThrow(NotFoundMemberException::new);
 
-        if (member.getDepartment().equals(ChangeDepartment.departmentNumber(departmentNumber))) {
-            return new MemberRankResDto(member.getMemberId(),
-                    member.getTier(),
-                    member.getScore(),
-                    member.getNickname(),
-                    member.getDepartment(),
-                    myDepartmentRanking(departmentNumber, member.getScore()));
-        } else {
-            return new MemberRankResDto(member.getMemberId(),
-                    member.getTier(),
-                    member.getScore(),
-                    member.getNickname(),
-                    member.getDepartment(),
-                    myRanking(member.getScore()));
-        }
+        int myRanking = member.getDepartment().equals(ChangeDepartment.departmentNumber(departmentNumber)) ?
+                myDepartmentRanking(departmentNumber, member.getScore()) : myRanking(member.getScore());
 
+        return new MemberRankResDto(member.getMemberId(),
+                member.getTier(),
+                member.getScore(),
+                member.getNickname(),
+                member.getDepartment(),
+                myRanking);
     }
 
     /**