Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

The great plague #124

Merged
merged 1 commit into from
Apr 6, 2024
Merged

The great plague #124

merged 1 commit into from
Apr 6, 2024

Conversation

RK22000
Copy link
Collaborator

@RK22000 RK22000 commented Apr 6, 2024

Deleted a few files
Refactored a bit to account for the deletions
moved away a demo file

chrehall68
chrehall68 suggested changes Apr 6, 2024
View reviewed changes
Copy link
Collaborator

@chrehall68 chrehall68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This created compatability issues because the bridge isn't currently used by captain. I would suggest not deleting those files and then we can have a separate pull request to move captain to use bridge instead of server gps.

chrehall68
chrehall68 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Collaborator

@chrehall68 chrehall68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for addressing the changes

@chrehall68 chrehall68 merged commit 0d6c7a5 into dev Apr 6, 2024
1 check passed
@chrehall68 chrehall68 deleted the TheGreatPlague branch April 6, 2024 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrehall68 chrehall68 chrehall68 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RK22000 @chrehall68