Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Michael fullscreen view #81

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Michael fullscreen view #81

merged 7 commits into from
Oct 6, 2023

Conversation

Mchan2003
Copy link
Contributor

No description provided.

@Mchan2003 Mchan2003 requested a review from evanugarte October 3, 2023 03:28
starphys
starphys requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@starphys starphys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I load the operational view for the first time, nothing appears where the cameras should be. I have to change the count of cameras before anything shows up. I think the state variable for number of cameras just needs to be initialized.

@Mchan2003
Copy link
Contributor Author

When I load the operational view for the first time, nothing appears where the cameras should be. I have to change the count of cameras before anything shows up. I think the state variable for number of cameras just needs to be initialized.

True. I think it doesn't work since I set it as null first. I just changed it to 1 and now it works.

@Mchan2003 Mchan2003 merged commit 0edb2b2 into main Oct 6, 2023
@starphys starphys removed the request for review from evanugarte October 6, 2023 02:09
@starphys starphys deleted the Michael-Fullscreen-view branch December 18, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starphys starphys starphys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mchan2003 @starphys