Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added protocol plugins - continuation of #958 #959

Merged
merged 92 commits into from
Oct 15, 2024
Merged

Added protocol plugins - continuation of #958 #959

merged 92 commits into from
Oct 15, 2024

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Oct 6, 2024 •
edited
Loading

Description

Continuation of PR #958, but with PR #939 merged in.

Added protocol plugins to separate protocol from storage driver. The protocol plugins are currently only implemented in Python.

Currently 3 protocols plugins has been added: file, http and sftp.

Suggestions from review:

  • Document that dlite.Instance.from_url() now support the following forms:
    - driver://netloc/path?options#id # old form
    - protocol+driver://netloc/path?options#id
    - protocol://netloc/path?driver=driver;options#id
  • Add test for file protocol with a file
  • Add test for file protocol with a directory
  • Add test for sftp protocol against sftp server on localhost
  • Document that it is possible for a plugin to only implement the from_bytes() or to_bytes() class methods

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

jesper-friis and others added 30 commits September 3, 2024 22:00
@jesper-friis
Updated installation of Python packages
e43afcd 
- include utility programs like dlite-getuuid
- include storages
- include README.md and LICENSE
@jesper-friis
Merge branch 'master' into python-package
755fa86
@jesper-friis
Generalised cmake statements by using generator expression
7524f2f
@jesper-friis
Merge branch 'master' into python-package
fc73705
@jesper-friis
Merge branch 'master' into python-package
ce3d247
@jesper-friis
Added two more tests
56f2d3a
@jesper-friis
Merge branch 'master' into python-package
574dcfa
@jesper-friis
Merge branch 'master' of github.com:SINTEF/dlite
26a0ca2
@jesper-friis
Made urlencode accessible from Python
ad17645
@jesper-friis
Windows doesn't cope with automatic allocated variables
52e77fc
@jesper-friis
Try to force utf-8 encoding on Windows
13d69b4
@jesper-friis
Ignore test of non-ascii characters on windows
b8226bc
@jesper-friis
Improve testing of uriencode()/uridecode()
1796706
@jesper-friis
Fixed some issues the Options class
8f0db75
@jesper-friis
Merge branch 'master' into python-package
1721dba
@jesper-friis
Initial work on Python protocol plugins
d95889d
@jesper-friis
Added sftp save() and delete() methods
432c47b
@jesper-friis
Updated C implementation of protocol paths
f3a05eb
@jesper-friis
work in progress...
3ee4ba6
@jesper-friis
Finalised implementation of protocols
badde98
@jesper-friis
Merge branch 'master' into protocols
d088ee3
@jesper-friis
Merge branch 'master' into protocols
beadf2c
@jesper-friis
Added test for Instance.load()
cc96d2d
@jesper-friis
Merge branch 'protocols' of github.com:SINTEF/dlite into protocols
4af05e5
@jesper-friis
Call load plugins at first thing when instantiating a dlite.Protocol
83c38a3
@jesper-friis
Added to tips and tricks
ecee45e
@jesper-friis
Merge branch 'python-package' into protocols2
544678f
@jesper-friis
Updated plugin paths and and fixed tests accordingly
a5960de
@jesper-friis
Merge branch 'python-package' into protocols2
01ad947
@jesper-friis
Updated installation paths
816e80b
@jesper-friis
Add compiler flag -lrt if needed
6195321
@jesper-friis
Added Python LDFLAGS
d68b9cd
@jesper-friis
Added more verbose printing
722fbc3
@jesper-friis
Adding -lrt to extra_link_libraries
7ad62e2
@jesper-friis
Reverted additional static linker flags
48f4fb0
@jesper-friis
Improved installation
74474b1
@jesper-friis
Updated protocol search path
f0ef0d1
@jesper-friis
Try to correct python install dirs on Windows
414deff
@jesper-friis
Handle the case that Python site directory equals its prefix
10510bf
@jesper-friis
Try to fix MSVS errors and warnings
0f2ac4e
@jesper-friis
Reduce MSVS warnings
2a77eea
@jesper-friis
Added test_plugin.py
8c25386
@jesper-friis
yet a test to satisfy windows
fe90dd6
@jesper-friis
Fixed logical error
0678dfa
@jesper-friis
Test to add a deliberate path with backslashes
c9f6fe9
@jesper-friis
Try to fix empty library on Windows and non-escaped backslashes in dl…
44a8a64 
…ite_PYTHONPATH
@jesper-friis
Fix cmake syntax
f3b4c24
@jesper-friis
Unset extra_link_libraries if it is empty
02af247
@jesper-friis
Fix warnings on MSVC
02ec567
@jesper-friis
Never append anything empty to extra_link_libraries
ed1e5dc
@jesper-friis
Get rid of warnings on int comparision tests
aa0b3ec
@jesper-friis
Unset extra_link_flags on MSVC
55144ad
@jesper-friis
More MSVC fixes
297e3c8
francescalb
francescalb approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, I am still missing a bit clearer description of which methods that must be implemented in a plugin and under which conditions.. See my suggestion. Something like this could (should) be added to the template, I think. Otherwise it seem OK.

@jesper-friis
Copy link
Collaborator Author

Good, I am still missing a bit clearer description of which methods that must be implemented in a plugin and under which conditions.. See my suggestion. Something like this could (should) be added to the template, I think. Otherwise it seem OK.

Good suggestion. I committed it.

@jesper-friis jesper-friis merged commit 761701a into master Oct 15, 2024
14 checks passed
@jesper-friis jesper-friis deleted the protocols2 branch October 15, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesper-friis @francescalb