Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up errors and made them more maintainable. #929

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

jesper-friis
Copy link
Collaborator

Description

  • Removed duplicated code
  • Use switch on enum to ensure that compiler warnings if not all places in the code are updated when a new error code is added.
  • Added NameError, PermissionError and InvalidMetadataError.
  • Renamed dliteSearchError to dliteLookupError for better correspondance with python.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

jesper-friis and others added 3 commits August 17, 2024 11:49
* Removed dupliated code
* Use switch on enum to ensure that compiler warnings if not all places in
  the code are updated when a new error code is added.
* Added NameError, PermissionError and InvalidMetadataError.
* Renamed dliteSearchError to dliteLookupError for better correspondance
  with python.
@jesper-friis jesper-friis merged commit 6f38fb4 into master Aug 17, 2024
14 checks passed
@jesper-friis jesper-friis deleted the error-cleanup branch August 17, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant